Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@115 PS11, Line 115: static bool IsValidIpv6Address(const string& candidate) { > use unordered_set<string_view> instead since you're just using it for compa Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@137 PS11, Line 137: bool has_colon = false; > Use unordered_set<string_view> to avoid unnecessary copies. Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@289 PS11, Line 289: } > BuildAliasReverseMap seems unnecessary can can possibly be removed? We coul Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@319 PS11, Line 319: continue; > we're returning a vector with every recursion and doing too many allocation Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@358 PS11, Line 358: > We could pass the vector by reference down the recursion tree. Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@395 PS11, Line 395: unordered_set<string_view> table_set; > We need ordering? If not we could just use a vector<string> here. We could Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@516 PS11, Line 516: static string UnredactTextWithAliases( > We're calling BuildApplyAndTrackAliases multiple times and essentially scan Done http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@573 PS11, Line 573: > local map seems unnecessary? You could directly pass `alias_to_original` an Done -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 12 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 02:45:39 +0000 Gerrit-HasComments: Yes
