Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/24282/12/be/src/service/query-profile-redaction.h File be/src/service/query-profile-redaction.h: http://gerrit.cloudera.org:8080/#/c/24282/12/be/src/service/query-profile-redaction.h@28 PS12, Line 28: class QueryProfileRedactor { I think we should add a detailed comment to the QueryProfileRedactor class to explain: Purpose and usage: What the class does and, at a high level, how it works, the expected lifecycle (e.g., calling Redact exactly once, and how unredact maps aliases back to the original text). Redacted Types: An explicit list of exactly what data types are currently targeted for redaction (e.g., SQL statements, Usernames/Emails, IPv4/IPv6 addresses, Table/Column names, Hostnames), and an example of the substitution (like original_table_name -> table_001). -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 12 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 03:04:07 +0000 Gerrit-HasComments: Yes
