Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser and Section Retrieval Interface ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc@320 PS11, Line 320: return Value(rapidjson::kObjectType); > Nit: This DCHECK is not needed since the DCHECK in GetSummaryPtr() covers t Done http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc@571 PS11, Line 571: > Calling .FindMember() is different from all the other places where .HasMemb Changed this to use .HasMember() for consistency http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc@1026 PS11, Line 1026: if (tool_name == "get_summary") { > Add a DCHECK(out_val != nullptr) above this line. Done http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/util/string-util.h File be/src/util/string-util.h: http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/util/string-util.h@50 PS11, Line 50: /// Splits text into lines using '\n' delimiters. > Nit: This function differs from other split functions because it creates s Done -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 12 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 21:16:02 +0000 Gerrit-HasComments: Yes
