Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser and Section Retrieval Interface ...................................................................... Patch Set 13: (9 comments) http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.h File be/src/service/query-profile-parsing-tools.h: http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.h@94 PS11, Line 94: std::string_view fragment_id, rapidjson::Document::AllocatorType& alloc) const; > I think we should call it GetPlanNode? The LLM might get confused between p Done http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc@121 PS11, Line 121: } > We could compute and cache the default limit at the first invocation: Done http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc@395 PS11, Line 395: if (pnp.IsObject() && !pnp.ObjectEmpty()) { > Should we make the logic deterministic? Basically `GetFragment` returns the Done http://gerrit.cloudera.org:8080/#/c/24283/11/be/src/service/query-profile-parsing-tools.cc@486 PS11, Line 486: sort(matches.begin(), matches.end(), > Wondering why is there a GetScanNodesSummary() and not generic GetNodesSumm We have GetNode(node_id, fragment_id), GetScanNodesSummary() is for many-node summarization http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@491 PS12, Line 491: row.AddMember("fragment", MakeJsonString(match->first, a > Can we use the pair<string_view, string_view> for fragment_key and node_key Done http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@712 PS12, Line 712: } > Is it an abnormal case if the query id is empty? Would it be good to add a Done http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@713 PS12, Line 713: eturn arr; > This seems fixed for the profile after query id is found, maybe we can have Done http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@906 PS12, Line 906: && parsed_[execution_profile_key_.c_str()].IsObject()) { : return &parsed_[execution_profile_key_. > From the reference in https://en.cppreference.com/cpp/string/byte/toupper. This method has been removed http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@924 PS12, Line 924: for (const auto& item : v.GetArray()) total += DictComplexity(item); > From the reference in https://en.cppreference.com/cpp/string/byte/toupper. This method has been removed -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 13 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 01:42:58 +0000 Gerrit-HasComments: Yes
