Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser and Section Retrieval Interface ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.h File be/src/service/query-profile-parsing-tools.h: http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.h@71 PS12, Line 71: explicit QueryProfileToolAccessor(ParsedProfile parsed); Could we add the following to explicitly disable the copy or move constructors? Since the class holds raw pointers, and not safe to copy. " QueryProfileToolAccessor(const QueryProfileToolAccessor&) = delete; QueryProfileToolAccessor& operator=(const QueryProfileToolAccessor&) = delete; QueryProfileToolAccessor(QueryProfileToolAccessor&&) = delete; QueryProfileToolAccessor& operator=(QueryProfileToolAccessor&&) = delete; " http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@491 PS12, Line 491: const string dedupe_key = fragment_key + "|" + node_key; Can we use the pair<string_view, string_view> for fragment_key and node_key, so that we can save the new string allocation cost? http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@712 PS12, Line 712: if (!query_id_.empty()) { Is it an abnormal case if the query id is empty? Would it be good to add a DCHECK that query id is non-empty here? http://gerrit.cloudera.org:8080/#/c/24283/12/be/src/service/query-profile-parsing-tools.cc@713 PS12, Line 713: const string key = string(EXECUTION_PROFILE_PREFIX) + " " + query_id_; This seems fixed for the profile after query id is found, maybe we can have a cached value for it like query_id_ as this function could be called multiple times -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 12 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 22:12:38 +0000 Gerrit-HasComments: Yes
