Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@74 PS9, Line 74: ParseUtil::ParseMemSpec Hit compilation error here. Changed to "impala::ParseUtil::ParseMemSpec" resolved it http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@380 PS9, Line 380: boost::algorithm::erase_tail(tool_json, : tool_json->size() - MAX_TOOL_RESULT_CHARS); Hit compilation error here. Changed from "tool_json" to "*tool_json" fix the issue http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@599 PS9, Line 599: string retry_message = strings::Substitute( : "The previous tool call for '$0' was ignored because tool_call id was " : "missing. Retry with a valid tool_call id.", : tool_name); Hit compilation error here. The Substitute doesn't accept string_view, change to "string(tool_name)" can fix it -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 9 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 01:48:05 +0000 Gerrit-HasComments: Yes
