Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@68 PS9, Line 68: using impala_udf::FunctionContext; : using impala_udf::StringVal; > Place the DEFINE_validator functions immediately below the DEFINE_* functio Done http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@61 PS9, Line 61: : DEFINE_string(query_profile_ai_analysis_profile_size_limit_percent, "1%", : "Maximum profile size as percentage of process_mem_limit for query-profile AI " : "analysis modules (e.g. 5%)."); : DEFINE_validator(query_profile_ai_analysis_profile_size_limit_percent, : ValidateQueryProfileAiAnalysisSizeLimitPercent); : : using impala_udf::FunctionContext; : using impala_udf::StringVal; > Use the gt_zero function defined in gflag-validator-util.h instead of defin Done http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@74 PS9, Line 74: using std::vector; > This function does not cap the returned value at 100%. It applies no cap a Done http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@74 PS9, Line 74: > Hit compilation error here. Done http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@95 PS9, Line 95: if (process_mem_limit <= 0) { : *profile_size_limit_bytes = byte_limit; : return Status::OK(); : } : > No need for this if statement, the validator on the query_profile_ai_analys Done http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@380 PS9, Line 380: // Builds the model request payload from the current conversation state. : static Status BuildAgentPayloadJson( > Hit compilation error here. Done http://gerrit.cloudera.org:8080/#/c/24284/9/be/src/service/query-profile-ai-analysis.cc@599 PS9, Line 599: << tool_status.GetDetail(); : Document tool_error_doc; : tool_error_doc.SetObject(); : Document::Alloc > Hit compilation error here. Done -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 11 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 01:54:41 +0000 Gerrit-HasComments: Yes
