Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.h File be/src/service/query-profile-ai-analysis.h: http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.h@36 PS7, Line 36: Status GenerateAiAnalysisFromProfile( > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@319 PS7, Line 319: "properties": {}, > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@537 PS7, Line 537: string payload_json; > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@530 PS7, Line 530: user_message.append(ANALYSIS_PROMPT) : .append("\n\nInitial profile context:\n") : .append(initial_summary_json.data(), initial_summary_json.size()); : conversation.emplace_back("user", std::move(user_message), "", ""); : : string last_response; : for (int iteration = 0; iteration < MAX_AGENT_ITERATIONS; ++iteration) { : string payload_json; : RETURN_IF_ERROR(BuildAgentPayloadJson(conversation, &payload_json)); : > Replace this code with a call to strings::Substitute("The previous tool cal Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@572 PS7, Line 572: JsonToString(tool_calls)); > As discussed, we can add the profile size and pass it to the Redactor and P Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@575 PS7, Line 575: if (!tool_call.IsObject()) continue; > Why is a copy of profile_text being created here instead of the previous wa Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@580 PS7, Line 580: if (!function.HasMember("name") || !function["name"].IsString()) continue; : : const Value& tool_name_value = function["name"]; : const string_view tool_name( : > It seems we don't need this logic, because the RedactQueryProfileWithAliase Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@614 PS7, Line 614: = tool_error_doc.GetAllocator(); > Why create copies of the tool_name and tools_args_json strings? Why not us Done http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@623 PS7, Line 623: continue; > line too long (96 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 8 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 21:08:11 +0000 Gerrit-HasComments: Yes
