Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser Interface ...................................................................... Patch Set 17: (6 comments) Fixed compilation issues http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@343 PS14, Line 343: best_by_fragment_id.insert_or_assign(bucket, item); > fragments_ is now a set, but it does not have the custom sorting function f Added the custom ordering back http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@453 PS14, Line 453: : Value QueryProfileToolAccessor::GetAllFragments( : string_view fragment_id, Document::AllocatorType& alloc) const { : const string normalized = NormalizeFragmentId(fragment_id); : multiset<const pair<string, const Value*>*, FragmentPtrLess> matches; : for (const auto& fragment : all_fragments_) { : > Define this struct in the private section of the QueryProfileToolAccessor c Done http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@1282 PS14, Line 1282: > We should replace all these magic strings "node_id" to NODE_ID_KEY, same to Done http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@1286 PS14, Line 1286: > We should replace these magic strings "fragment_id" to FRAGMENT_ID_KEY, sam Done http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@1299 PS14, Line 1299: K(); > We can define a common template for the error message: Done http://gerrit.cloudera.org:8080/#/c/24283/15/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/15/be/src/service/query-profile-parsing-tools.cc@1334 PS15, Line 1334: > Looks like we can have the same for "instance_id", maybe INSTANCE_ID_KEY li Done -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 17 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 05:51:08 +0000 Gerrit-HasComments: Yes
