Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser and Section Retrieval Interface ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@1282 PS14, Line 1282: node_id We should replace all these magic strings "node_id" to NODE_ID_KEY, same to all in this function. http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@1286 PS14, Line 1286: fragment_id We should replace these magic strings "fragment_id" to FRAGMENT_ID_KEY, same to all in this function. http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@1299 PS14, Line 1299: "tool 'get_average_operator' requires string argument 'node_id'" We can define a common template for the error message: "static constexpr const char MISSING_ARG_ERROR_MSG[] = "tool '$0' requires string argument '$1'";" Then change here to: "return Status(Substitute(MISSING_ARG_ERROR_MSG, tool_name, NODE_ID_KEY));" Same to all the below similar error messages. -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 14 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 05:18:41 +0000 Gerrit-HasComments: Yes
