Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser Interface ...................................................................... Patch Set 18: (6 comments) http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc@1296 PS16, Line 1296: } else { clang tidy error: be/src/service/query-profile-parsing-tools.cc:1308:21: error: use of undeclared identifier 'Substitute'; did you mean 'strings::Substitute'? return Status(Substitute(MISSING_ARG_ERROR_MSG, string(tool_name), NODE_ID_KEY)); ^~~~~~~~~~ strings::Substitute /home/ubuntu/Impala/be/src/gutil/strings/substitute.h:172:15: note: 'strings::Substitute' declared here inline string Substitute( ^ http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc@1308 PS16, Line 1308: } else { clang tidy error: be/src/service/query-profile-parsing-tools.cc:1308:21: error: use of undeclared identifier 'Substitute'; did you mean 'strings::Substitute'? return Status(Substitute(MISSING_ARG_ERROR_MSG, string(tool_name), NODE_ID_KEY)); ^~~~~~~~~~ strings::Substitute /home/ubuntu/Impala/be/src/gutil/strings/substitute.h:172:15: note: 'strings::Substitute' declared here inline string Substitute( ^ http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc@1315 PS16, Line 1315: return Status( clang tidy error: be/src/service/query-profile-parsing-tools.cc:1315:11: error: use of undeclared identifier 'Substitute'; did you mean 'strings::Substitute'? Substitute(MISSING_ARG_ERROR_MSG, string(tool_name), FRAGMENT_ID_KEY)); ^~~~~~~~~~ strings::Substitute /home/ubuntu/Impala/be/src/gutil/strings/substitute.h:172:15: note: 'strings::Substitute' declared here inline string Substitute( ^ http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc@1328 PS16, Line 1328: } else { clang tidy error: be/src/service/query-profile-parsing-tools.cc:1328:21: error: use of undeclared identifier 'Substitute'; did you mean 'strings::Substitute'? return Status(Substitute(MISSING_ARG_ERROR_MSG, string(tool_name), NODE_ID_KEY)); ^~~~~~~~~~ strings::Substitute /home/ubuntu/Impala/be/src/gutil/strings/substitute.h:172:15: note: 'strings::Substitute' declared here inline string Substitute( ^ http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc@1335 PS16, Line 1335: return Status( clang tidy error: be/src/service/query-profile-parsing-tools.cc:1335:11: error: use of undeclared identifier 'Substitute'; did you mean 'strings::Substitute'? Substitute(MISSING_ARG_ERROR_MSG, string(tool_name), FRAGMENT_ID_KEY)); ^~~~~~~~~~ strings::Substitute /home/ubuntu/Impala/be/src/gutil/strings/substitute.h:172:15: note: 'strings::Substitute' declared here inline string Substitute( ^ http://gerrit.cloudera.org:8080/#/c/24283/16/be/src/service/query-profile-parsing-tools.cc@1342 PS16, Line 1342: return Status( clang tidy error: be/src/service/query-profile-parsing-tools.cc:1342:11: error: use of undeclared identifier 'Substitute'; did you mean 'strings::Substitute'? Substitute(MISSING_ARG_ERROR_MSG, string(tool_name), INSTANCE_ID_KEY)); ^~~~~~~~~~ strings::Substitute /home/ubuntu/Impala/be/src/gutil/strings/substitute.h:172:15: note: 'strings::Substitute' declared here inline string Substitute( ^ -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 18 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 05:50:43 +0000 Gerrit-HasComments: Yes
