Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 6:
>
> Build Failed 
>
> https://jenkins.impala.io/job/gerrit-code-review-checks/22509/ : Initial code 
> review checks failed. See linked job for details on the failure.

Failed due to the following error.

 18:50:03 01:50:02 [INFO] Apache Impala Query Engine Frontend 5.0.0-SNAPSHOT . 
FAILURE [  8.609 s]
 18:50:03 01:50:02 [INFO] BUILD FAILURE
 18:50:03 01:50:02 [ERROR] Failed to execute goal on project impala-frontend: 
Could not collect dependencies for project 
org.apache.impala:impala-frontend:jar:5.0.0-SNAPSHOT
 18:50:03 01:50:02 [ERROR] Failed to read artifact descriptor for 
net.shibboleth.tool:xmlsectool:jar:2.0.0
 18:50:03 01:50:02 [ERROR]      Caused by: The following artifacts could not be 
resolved: net.shibboleth.tool:xmlsectool:pom:2.0.0 (absent): Could not transfer 
artifact net.shibboleth.tool:xmlsectool:pom:2.0.0 from/to impala.cdp.repo 
(https://native-toolchain-us-west-2.s3.us-west-2.amazonaws.com/build/cdp_components/73534044/maven):
 status code: 403, reason phrase: Forbidden (403)

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File 
fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@248
PS6, Line 248:       auditGrantRevokeRole(header, GRANT_ROLE_ACTION, isAllowed, 
requestingUser);
It may be a good idea to log the time spent on this operation like what we do 
at 
https://github.com/apache/impala/blob/18ed94d/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java#L343-L344.



--
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 19 May 2026 16:39:47 +0000
Gerrit-HasComments: Yes

Reply via email to