Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )
Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24315/8/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java: http://gerrit.cloudera.org:8080/#/c/24315/8/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@257 PS8, Line 257: assertEquals(policyId, event.getPolicyId()); The tests may be easier to maintain if we do not check the exact policy id. For instance, the policy id of a given policy, e.g., "all - database", could be different for a different version of Ranger server. -- To view, visit http://gerrit.cloudera.org:8080/24315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61 Gerrit-Change-Number: 24315 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 23:26:35 +0000 Gerrit-HasComments: Yes
