Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )
Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE ...................................................................... Patch Set 8: (3 comments) Addressed some of my own comments on patch set 6. Let me know if there are additional suggestions. Thanks very much for the help! http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java: http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@124 PS6, Line 124: /* result > If we instantiate a GrantRevokeRoleStmt, then we could call its toSql() to This is addressed in the patch set 8. http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@161 PS6, Line 161: assertEventEquals(events.get(0), ALTER_ACTION, ALTER_ACCESS_TYPE > If we instantiate a GrantRevokeRoleStmt, then we could call its toSql() to This is addressed in the patch set 8. http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@201 PS6, Line 201: resultChecker.accept(capturedAuditHandlers); : } finally { : TCatalogServiceRequestHeader adminHeader = createHeader(RANGER_ADMIN.getName(), : "revoke role " + role + " from " + granteeUser, CLIENT_IP_ADDRESS); : authzManager.revokeRoleFromGroupOrUser(adminHeader, params, : new TDdlExecResponse(new TCatalogUpdateResult())); : capturedAuditHandlers.clear(); : } : } : : private void revokeRole(Consumer<List<AutoFlush>> resultChecker, String revokerUser, : String role, String revokeeGroup, String revokeeUser, boolean expectSuccess) : throws Exception { : > We may be able to re-use the code at https://github.com/apache/impala/blob/ This is addressed in the patch set 8. -- To view, visit http://gerrit.cloudera.org:8080/24315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61 Gerrit-Change-Number: 24315 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 19:35:00 +0000 Gerrit-HasComments: Yes
