Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24313 )
Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services on Kubernetes ...................................................................... Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/24313/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24313/6//COMMIT_MSG@16 PS6, Line 16: Please add details on how these charts were tested. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/catalogd-deployment.yaml File helm/impala/templates/catalogd-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/catalogd-deployment.yaml@59 PS6, Line 59: - -v=1 Make the debug level configurable via a property, and keep the default as 1. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml File helm/impala/templates/impalad-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@57 PS6, Line 57: - -v=1 Make the debug level configurable via a property, and keep the default as 1. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@65 PS6, Line 65: {{- if .Values.auth.ldap.enabled }} Also add support for OAuth auth as that auth method is much more likely to be used than LDAP. This could be done in a follow-up Jira as well (note the new Jira number in these gerrit comments). http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@89 PS6, Line 89: - name: beeswax : containerPort: 21000 Beeswax server is no longer started by default, and the protocol is deprecated. Let's not expose the Beeswax port at all. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-service.yaml File helm/impala/templates/impalad-service.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-service.yaml@40 PS6, Line 40: - name: beeswax : port: 21000 : targetPort: beeswax Don't expose Beeswax port. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/statestored-deployment.yaml File helm/impala/templates/statestored-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/statestored-deployment.yaml@59 PS6, Line 59: - -v=1 Make the debug level configurable via a property, and keep the default as 1. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml File helm/impala/values.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml@21 PS6, Line 21: prefix: "" This should default to "apache/impala:4.5.0-". http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml@51 PS6, Line 51: We should also have support for running a secure cluster. This could be done in a follow-up Jira as well (note the new Jira number in these gerrit comments). For details on the configuration options that need to be set, see this commit: https://github.com/apache/impala/commit/417ba2d3eb1d252eb21834d1cf6f9e4f21ba49f9#diff-8ec0de1ff681b1d15556ee31499654f330f201c09adcd0a5d365278d3f3a88f9 -- To view, visit http://gerrit.cloudera.org:8080/24313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b Gerrit-Change-Number: 24313 Gerrit-PatchSet: 6 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 19:39:09 +0000 Gerrit-HasComments: Yes
