Anubhav Jindal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24313 )

Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services 
on Kubernetes
......................................................................


Patch Set 7:

(9 comments)

Addressed the in-scope feedback in this patchset (configurable -v, default 
image prefix, remove Beeswax exposure, and testing details in commit message). 
OAuth and secure-cluster support are broader and I have filed follow-up JIRAs.

http://gerrit.cloudera.org:8080/#/c/24313/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24313/6//COMMIT_MSG@16
PS6, Line 16:
> Please add details on how these charts were tested.
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/catalogd-deployment.yaml
File helm/impala/templates/catalogd-deployment.yaml:

http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/catalogd-deployment.yaml@59
PS6, Line 59:             - -v={{ .Values.catalogd.v | default 1 }}
> Make the debug level configurable via a property, and keep the default as 1
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml
File helm/impala/templates/impalad-deployment.yaml:

http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@57
PS6, Line 57:             - -v={{ .Values.impalad.v | default 1 }}
> Make the debug level configurable via a property, and keep the default as 1
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@65
PS6, Line 65: {{- if .Values.auth.ldap.enabled }}
> Also add support for OAuth auth as that auth method is much more likely to 
Filed a new JIRA for OAuth: IMPALA-15016


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@89
PS6, Line 89:             - name: hs2
            :               containerPort: 21050
> Beeswax server is no longer started by default, and the protocol is depreca
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-service.yaml
File helm/impala/templates/impalad-service.yaml:

http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-service.yaml@40
PS6, Line 40:     - name: hs2
            :       port: 21050
            :       targetPort: hs2
> Don't expose Beeswax port.
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/statestored-deployment.yaml
File helm/impala/templates/statestored-deployment.yaml:

http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/statestored-deployment.yaml@59
PS6, Line 59:             - -v={{ .Values.statestored.v | default 1 }}
> Make the debug level configurable via a property, and keep the default as 1
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml
File helm/impala/values.yaml:

http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml@21
PS6, Line 21:   prefix: "apache/impala:4.5.0-"
> This should default to "apache/impala:4.5.0-".
Done


http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml@51
PS6, Line 51: hms:
> We should also have support for running a secure cluster.  This could be do
Filed a separate JIRA to add secure-cluster configuration support to Impala 
Helm chart: IMPALA-15017



--
To view, visit http://gerrit.cloudera.org:8080/24313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b
Gerrit-Change-Number: 24313
Gerrit-PatchSet: 7
Gerrit-Owner: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Comment-Date: Tue, 19 May 2026 21:27:43 +0000
Gerrit-HasComments: Yes

Reply via email to