Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24313 )
Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services on Kubernetes ...................................................................... Patch Set 8: Code-Review+1 (11 comments) http://gerrit.cloudera.org:8080/#/c/24313/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24313/6//COMMIT_MSG@16 PS6, Line 16: > Done Done http://gerrit.cloudera.org:8080/#/c/24313/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24313/8//COMMIT_MSG@17 PS8, Line 17: Address review feedback by removing Beeswax service exposure, : setting a stable default image prefix, and making daemon -v levels : configurable via values. No need to mention specific review feedback in the commit message since the gerrit comments are always available to be viewed later. That being said, it would be good to mention that the Impala 4.5.0 quickstart images are being used and that the Beeswax port is not exposed. http://gerrit.cloudera.org:8080/#/c/24313/8//COMMIT_MSG@25 PS8, Line 25: - https://jenkins.impala.io/job/gerrit-code-review-checks/22506/ No need to mention the specific code review checks build as that build automatically adds success/failed comments. http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/catalogd-deployment.yaml File helm/impala/templates/catalogd-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/catalogd-deployment.yaml@59 PS6, Line 59: - -v={{ .Values.catalogd.v | default 1 }} > Done Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml File helm/impala/templates/impalad-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@57 PS6, Line 57: - -v={{ .Values.impalad.v | default 1 }} > Done Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@65 PS6, Line 65: {{- if .Values.auth.ldap.enabled }} > Filed a new JIRA for OAuth: IMPALA-15016 Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-deployment.yaml@89 PS6, Line 89: - name: hs2 : containerPort: 21050 > Done Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-service.yaml File helm/impala/templates/impalad-service.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/impalad-service.yaml@40 PS6, Line 40: - name: hs2 : port: 21050 : targetPort: hs2 > Done Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/statestored-deployment.yaml File helm/impala/templates/statestored-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/templates/statestored-deployment.yaml@59 PS6, Line 59: - -v={{ .Values.statestored.v | default 1 }} > Done Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml File helm/impala/values.yaml: http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml@21 PS6, Line 21: prefix: "apache/impala:4.5.0-" > Done Done http://gerrit.cloudera.org:8080/#/c/24313/6/helm/impala/values.yaml@51 PS6, Line 51: extraArgs: [] > Filed a separate JIRA to add secure-cluster configuration support to Impala Done -- To view, visit http://gerrit.cloudera.org:8080/24313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b Gerrit-Change-Number: 24313 Gerrit-PatchSet: 8 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 16:16:52 +0000 Gerrit-HasComments: Yes
