Hello Quanlong Huang, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24358
to look at the new patch set (#4).
Change subject: IMPALA-12955: Slim down profile tool deps
......................................................................
IMPALA-12955: Slim down profile tool deps
Split impala-profile-tool dependencies into smaller link units so
the tool no longer pulls in unused runtime libraries such as HDFS,
JVM, Kudu, SASL, Kerberos, SSL, and crypto dependencies.
The existing Status, ErrorMsg, and RuntimeProfile source files keep
the same exported behavior for the main Impala libraries. The profile
tool links a lightweight Status subset with the non-debug
Status::Expected() API, ErrorMsg formatting, archive-only
RuntimeProfile helpers, and a static thrift subset containing only
profile-related generated thrift code.
The profile tool source lists are reused by the full library source
lists to avoid CMake drift when files are added to both targets.
A Linux-only pytest verifies that impala-profile-tool dynamic deps do
not regress and start pulling the removed libraries again.
Tests:
- ./buildall.sh -notests -noclean -cmake_only
- make -C be/src/util impala-profile-tool
- ./buildall.sh -release -so -notests -noclean -cmake_only
- make -C be/src/util impala-profile-tool (RELEASE, shared)
- readelf -d be/build/release/util/impala-profile-tool | grep NEEDED
- bin/impala-python3 -m pytest \
tests/observability/test_profile_tool.py \
tests/observability/test_profile_tool_dependencies.py -q
- python3 bin/jenkins/critique-gerrit-review.py --dryrun
- git diff --check
Generated-by: OpenAI Codex
Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
---
M be/generated-sources/gen-cpp/CMakeLists.txt
M be/src/common/CMakeLists.txt
A be/src/common/status-core.cc
M be/src/common/status.cc
M be/src/runtime/mem-pool.h
A be/src/runtime/summary-stats.h
M be/src/util/CMakeLists.txt
M be/src/util/cpu-info.cc
A be/src/util/error-msg.cc
M be/src/util/error-util.cc
A be/src/util/runtime-profile-archive.cc
A be/src/util/runtime-profile-periodic.cc
A be/src/util/runtime-profile-serialization.cc
M be/src/util/runtime-profile.cc
A tests/observability/test_profile_tool_dependencies.py
15 files changed, 904 insertions(+), 519 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/24358/4
--
To view, visit http://gerrit.cloudera.org:8080/24358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
