Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24358 )
Change subject: IMPALA-12955: Slim down profile tool deps ...................................................................... Patch Set 4: (3 comments) Nice work! The size of impala-profile-tool reduces from 478MB to 12MB in my env. I just have some minor comments. http://gerrit.cloudera.org:8080/#/c/24358/4/be/src/util/runtime-profile-archive.cc File be/src/util/runtime-profile-archive.cc: http://gerrit.cloudera.org:8080/#/c/24358/4/be/src/util/runtime-profile-archive.cc@88 PS4, Line 88: if ((archive_str.size() & 3) != 0) { nit: Could you add a comment about this? http://gerrit.cloudera.org:8080/#/c/24358/4/be/src/util/runtime-profile-archive.cc@90 PS4, Line 90: "Error in DeserializeFromArchiveString: Base64DecodeBufLen failed."); The error messages need to be updated. http://gerrit.cloudera.org:8080/#/c/24358/4/be/src/util/runtime-profile-archive.cc@166 PS4, Line 166: RETURN_IF_ERROR(DecodeArchiveString(archive_str, &decoded_buffer)); This is not a pure move. The original code is: https://github.com/apache/impala/blob/ac1e178ad3915dba8764e8534bce310f889a03f4/be/src/util/runtime-profile.cc#L1731-L1743 Can we mention this and other refactored/rewritten codes in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/24358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Gerrit-Change-Number: 24358 Gerrit-PatchSet: 4 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 05:05:20 +0000 Gerrit-HasComments: Yes
