Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24358 )
Change subject: IMPALA-12955: Slim down profile tool deps ...................................................................... Patch Set 4: Thanks Michael. PS4 addresses the two CMake source-list comments by defining the profile-tool source subsets once and reusing them from the full target source lists. That should avoid the drift you pointed out if we need to add another generated thrift file or util source to both targets later. I also tightened the Status split after thinking about your note. The split is still intentionally smaller than introducing separate Status classes, but status-core.cc now has a clearer boundary: it contains the dependency-light Status methods that do not need debug, proto, or thrift helpers. That includes all Status::Expected(TErrorCode, ...) overloads, so ProfileToolCommon no longer exports only the exact narrow subset used by the current profile-tool call chain. The heavier constructors, stacktrace logging, HS2/TStatus handling, and proto/thrift conversions remain in status.cc and are still linked by the full Common target. I left the static Status initialization behavior unchanged and added a short comment documenting the dependency boundary for status-core.cc. Validation was run in a fresh Lima VM worktree with the exact PS4 patch: - ./buildall.sh -notests -noclean -cmake_only - make -C be/src/util impala-profile-tool - bin/impala-python3 -m pytest tests/observability/test_profile_tool.py \ tests/observability/test_profile_tool_dependencies.py -q - ./buildall.sh -release -so -notests -noclean -cmake_only - make -C be/src/util impala-profile-tool (RELEASE, shared) - readelf -d be/build/release/util/impala-profile-tool | grep NEEDED - git diff --check The release/shared NEEDED list still contains only ProfileToolCommon, ProfileToolUtil, gutil, glog, gflags, and the C/C++ runtime libraries. -- To view, visit http://gerrit.cloudera.org:8080/24358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Gerrit-Change-Number: 24358 Gerrit-PatchSet: 4 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2026 21:18:55 +0000 Gerrit-HasComments: No
