Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 )
Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode ...................................................................... Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/exec-node.cc@310 PS4, Line 310: *node = pool->Add(new AggregationNode(pool, tnode, descs)); : } > I added this because its generally nice to have safety valves in case of re Thanks for removing it. http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.h File be/src/exec/grouping-aggregator.h: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.h@130 PS4, Line 130: /// streamed through and returned in 'out_batch'. AddBatch() and AddBatchStreaming() > I think it would be fine, but since there's no reason to and its not tested Okay. i'm fine either way - I just wasn't sure if it was a requirement or not. http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.cc File be/src/exec/grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.cc@91 PS4, Line 91: is_streaming_preagg_(tnode.agg_node.use_streaming_preaggregation), > Yes but a GroupingAggregator can be used with either the StreamingAggNode o Right, I was imaging that eventually we'll have separate thrift nodes for AggNode and StreamingAggNode, at which time we'd get rid of this thrift boolean and instead the constructor would just take a boolean constant depending on the callsite. But maybe we don't plan to have the same class structure in the frontend and in thrift? -- To view, visit http://gerrit.cloudera.org:8080/10394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e7bb583f54aa4add3738bde7f57cf3511ac567e Gerrit-Change-Number: 10394 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 03:25:15 +0000 Gerrit-HasComments: Yes
