Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 )
Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/exec-node.cc@310 PS4, Line 310: if (FLAGS_use_legacy_aggregation) { : *node = pool->Add(new PartitionedAggregationNode(pool, tnode, descs)); > i guess we need to at least keep it until the frontend change is in to use Oops, ignore the previous comment. I wrote it without re-reading this code, which obviously generates the new exec nodes even without the frontend changes, which is okay for now. -- To view, visit http://gerrit.cloudera.org:8080/10394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e7bb583f54aa4add3738bde7f57cf3511ac567e Gerrit-Change-Number: 10394 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 15:22:07 +0000 Gerrit-HasComments: Yes
