Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 )
Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode ...................................................................... Patch Set 4: Code-Review+1 (3 comments) This all seems pretty good to me. Tim should take a pass as well. http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/exec-node.cc@310 PS4, Line 310: if (FLAGS_use_legacy_aggregation) { : *node = pool->Add(new PartitionedAggregationNode(pool, tnode, descs)); > do we need to keep this code around? i guess we need to at least keep it until the frontend change is in to use the new exec nodes. Do we have a change that does that without changing functionality, or is it all bundled with the multiple distinct frontend changes? http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.h File be/src/exec/grouping-aggregator.h: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.h@130 PS4, Line 130: /// streamed through and returned in 'out_batch'. is it a rule that AddBatchStreaming() and AddBatch() shouldn't both be used on the same aggregator? http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.cc File be/src/exec/grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/10394/4/be/src/exec/grouping-aggregator.cc@91 PS4, Line 91: is_streaming_preagg_(tnode.agg_node.use_streaming_preaggregation), should this be implied by the exec node type, now that we have a distinct exec node for pre-agg? -- To view, visit http://gerrit.cloudera.org:8080/10394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e7bb583f54aa4add3738bde7f57cf3511ac567e Gerrit-Change-Number: 10394 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 00:28:06 +0000 Gerrit-HasComments: Yes
