Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24369 )
Change subject: IMPALA-14782: Use CatalogUtil instead of Catalogs ...................................................................... Patch Set 2: (4 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24369/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24369/2//COMMIT_MSG@14 PS2, Line 14: icebrg typo http://gerrit.cloudera.org:8080/#/c/24369/2//COMMIT_MSG@15 PS2, Line 15: catalog. > Idk if we need this though. This is the comment from https://github.com/apa It's not critical. Impala has 'iceberg.catalog'='hadoop.tables' for HadoopTables. http://gerrit.cloudera.org:8080/#/c/24369/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java: http://gerrit.cloudera.org:8080/#/c/24369/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@53 PS2, Line 53: IcebergCatalogs We named it IcebergCatalogs because it was built upon Iceberg's Catalogs class. We hava the same pattern with IcebergHiveCatalog, IcebergHadoopCatalog, etc.. To avoid confusion in the future, we should rename this to IcebergCatalogUtil. http://gerrit.cloudera.org:8080/#/c/24369/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@59 PS2, Line 59: TABLE_IDENTIFIER You could add a comment that it is based on InputFormatConfig.TABLE_IDENTIFIER. -- To view, visit http://gerrit.cloudera.org:8080/24369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica56a3223e9d6fa08a6cec52b8c8d8869afa8ca5 Gerrit-Change-Number: 24369 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 13:21:34 +0000 Gerrit-HasComments: Yes
