Mihaly Szjatinya has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/24369 )
Change subject: IMPALA-14782: Use CatalogUtil instead of Catalogs
......................................................................
IMPALA-14782: Use CatalogUtil instead of Catalogs
This change gets rid of iceberg-mr dependency by calling the Iceberg's
CatalogUtil and *Catalog methods directly. Also some constants were
replaced. The former wrapper class IcebergCalalogs is now renamed to
IcebergCatalogUtil.
Most of the logic from Catalogs is preserved, except for
'iceberg.catalog.location_based_table' being resolved to HadoopTable
catalog.
Note: renameTable, which was unsupported for Catalogs, is now calling
the underlying catalog's renameTable() directly, same as other
functions. For HadoopTable however it's still an unsupported operation,
but the error we're getting is more precise.
Testing:
- Ran following tests involving IcebergCatalogs:
test_iceberg.py::TestIcebergTable::test_catalogs
test_iceberg.py::TestIcebergTable::test_expire_snapshots
test_iceberg.py::TestIcebergTable::test_execute_rollback
test_events_custom_configs.py::TestEventProcessingCustomConfigs \
::test_iceberg_self_events
Change-Id: Ica56a3223e9d6fa08a6cec52b8c8d8869afa8ca5
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
R fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogUtil.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M fe/src/test/java/org/apache/impala/util/IcebergUtilTest.java
M java/shaded-deps/impala-iceberg-runtime/pom.xml
9 files changed, 101 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/24369/3
--
To view, visit http://gerrit.cloudera.org:8080/24369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica56a3223e9d6fa08a6cec52b8c8d8869afa8ca5
Gerrit-Change-Number: 24369
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
