Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24369 )
Change subject: IMPALA-14782: Use CatalogUtil instead of Catalogs ...................................................................... Patch Set 2: (4 comments) Thanks for review! Fixed the suggestions. Also I've brought back another transient dependency which was causing regression. http://gerrit.cloudera.org:8080/#/c/24369/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24369/2//COMMIT_MSG@14 PS2, Line 14: icebrg > typo Ack http://gerrit.cloudera.org:8080/#/c/24369/2//COMMIT_MSG@15 PS2, Line 15: catalog. > It's not critical. Impala has 'iceberg.catalog'='hadoop.tables' for HadoopT Ack http://gerrit.cloudera.org:8080/#/c/24369/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java: http://gerrit.cloudera.org:8080/#/c/24369/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@53 PS2, Line 53: IcebergCatalogs > We named it IcebergCatalogs because it was built upon Iceberg's Catalogs cl Yeah I was wondering as well weather to keep the name. Done. http://gerrit.cloudera.org:8080/#/c/24369/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@59 PS2, Line 59: TABLE_IDENTIFIER > You could add a comment that it is based on InputFormatConfig.TABLE_IDENTIF Ack -- To view, visit http://gerrit.cloudera.org:8080/24369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica56a3223e9d6fa08a6cec52b8c8d8869afa8ca5 Gerrit-Change-Number: 24369 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 16:02:14 +0000 Gerrit-HasComments: Yes
