Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24153 )
Change subject: IMPALA-14597: Initial HBO support ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1944 PS13, Line 1944: public void appendInputStats(TPlanNodeRun execStats) { > We need this append sematic since for plan nodes that have multiple childre Ah, I'm sorry. I stated the wrong thing. I'm never a big fan of methods that mutate variables. Can we change this method to "TScanInputStats createScanInputStats()" so the mutation of the TPlanNodeRun exists where the variable is created? http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1031 PS13, Line 1031: if (hashString == null) break; > Right, in this patch, only HdfsScanNode uses it. I can use Preconditions ch Heh, nah, that'll cause a merge problem on the rebase. It's ok to leave it :) http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/service/HistoricalStats.java File fe/src/main/java/org/apache/impala/service/HistoricalStats.java: http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/service/HistoricalStats.java@60 PS13, Line 60: : 100; > Yeah, for EXPR_REWRITE which is the safest and most conservative strategy, Got it, thanks! http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/service/HistoricalStats.java@190 PS13, Line 190: Preconditions.checkArgument(!currRun.getScan_input_stats().isEmpty()); > PlanNodes with multiple leaves scan nodes will have size > 1 here. We will Ack -- To view, visit http://gerrit.cloudera.org:8080/24153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ff60a8bd22c13c0ecad1198934cc96249b1015e Gerrit-Change-Number: 24153 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2026 15:39:05 +0000 Gerrit-HasComments: Yes
