Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24153 )
Change subject: IMPALA-14597: Initial HBO support ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24153/13/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1944 PS13, Line 1944: LOG.trace("HBO CONJUNCT STR ({}, {}): {}", statsType, strategy, s); > Ah, I'm sorry. I stated the wrong thing. Yeah, we can do this for scan node since it's a leaf node. However, for ancestor nodes like JoinNode, its subtree has multiple leaf nodes. We need to return a list of TScanInputStats. It's a waste to create these lists and concatenate them for ancestor nodes (follow-up patches need this). However, we can still do an optimization that each node keeps its TScanInputStats list instead of creating it everytime. Then the cost of concatenating the lists won't be large. I plan to add an optimization on caching HBO key string instead of generating it everytime using a similar mechanism. Maybe in a future patch after HBO supports all PlanNodes, so we can avoid complicating this patch. Do you think it's OK? -- To view, visit http://gerrit.cloudera.org:8080/24153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ff60a8bd22c13c0ecad1198934cc96249b1015e Gerrit-Change-Number: 24153 Gerrit-PatchSet: 15 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 13:48:24 +0000 Gerrit-HasComments: Yes
