Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24153 )
Change subject: IMPALA-14597: Initial HBO support ...................................................................... Patch Set 17: Code-Review+1 (2 comments) I am joining the review cycle late. I think the existing reviewers have already provided great feedback (and you have addressed most of them), so I just have a couple below. Otherwise, I am generally good with this patch and can bump my vote up based on your input. http://gerrit.cloudera.org:8080/#/c/24153/17/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24153/17/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@56 PS17, Line 56: public static List<String> canonicalizeScanConjuncts(List<Expr> exprs, FeTable table, For sufficiently complex expressions, there could be a not trivial cost of doing the canonicalization. Should we put some default limit on the total number of conjuncts to be considered ? http://gerrit.cloudera.org:8080/#/c/24153/17/testdata/workloads/functional-query/queries/QueryTest/hbo-collection-scan.test File testdata/workloads/functional-query/queries/QueryTest/hbo-collection-scan.test: http://gerrit.cloudera.org:8080/#/c/24153/17/testdata/workloads/functional-query/queries/QueryTest/hbo-collection-scan.test@1 PS17, Line 1: ==== These tests are great. One suggestion is to add one with sufficient number of disjunctions - I recall that as the number of disjunctions grow, the estimates get completely out of range. This is a strong use case for HBO. -- To view, visit http://gerrit.cloudera.org:8080/24153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ff60a8bd22c13c0ecad1198934cc96249b1015e Gerrit-Change-Number: 24153 Gerrit-PatchSet: 17 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2026 22:54:34 +0000 Gerrit-HasComments: Yes
