Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24259 )
Change subject: IMPALA-14930: Auto comments on unused imports in Java ...................................................................... Patch Set 2: Code-Review+1 Looks great, welcome patch. Do we have any plans to move away from custom solutions and use something like spotless for Java? We currently enforce rules in critic-gerrit-review.py and the .clang-format file, we could migrate the rules to a spotless configuration and critic-gerrit-review.py could simply call the spotless plugin. Spotless has a lot more configuration options and we could really enforce the Impala Java code style with it. -- To view, visit http://gerrit.cloudera.org:8080/24259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a260c05e02e96aaf1331bc31ed92b0e368403bd Gerrit-Change-Number: 24259 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 09:43:40 +0000 Gerrit-HasComments: No
