Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24259 )
Change subject: IMPALA-14930: Auto comments on unused imports in Java ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/24259/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24259/2//COMMIT_MSG@13 PS2, Line 13: flake8 (F401), the script simply uses string parsing to extract imported I had tried to enable linting on Java, but there were other issues I couldn't find a workaround for. This seems like a reasonable intermediate step. http://gerrit.cloudera.org:8080/#/c/24259/2/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/24259/2/bin/jenkins/critique-gerrit-review.py@235 PS2, Line 235: body = re.sub(r"^\s*static\s+", "", body).strip() This looks the same as _java_star_import_body. http://gerrit.cloudera.org:8080/#/c/24259/2/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java: http://gerrit.cloudera.org:8080/#/c/24259/2/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java@20 PS2, Line 20: nit: why the extra newline? http://gerrit.cloudera.org:8080/#/c/24259/2/fe/src/main/java/org/apache/impala/util/FunctionUtils.java File fe/src/main/java/org/apache/impala/util/FunctionUtils.java: http://gerrit.cloudera.org:8080/#/c/24259/2/fe/src/main/java/org/apache/impala/util/FunctionUtils.java@24 PS2, Line 24: Why an extra newline? -- To view, visit http://gerrit.cloudera.org:8080/24259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a260c05e02e96aaf1331bc31ed92b0e368403bd Gerrit-Change-Number: 24259 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 18:11:41 +0000 Gerrit-HasComments: Yes
