Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24259 )

Change subject: IMPALA-14930: Auto comments on unused imports in Java
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24259/2/bin/jenkins/critique-gerrit-review.py
File bin/jenkins/critique-gerrit-review.py:

http://gerrit.cloudera.org:8080/#/c/24259/2/bin/jenkins/critique-gerrit-review.py@235
PS2, Line 235: def get_unused_import_comments(base_revision, revision):
> Yeah, also moved this above so _is_java_star_import_allowed() doesn't need
Done



--
To view, visit http://gerrit.cloudera.org:8080/24259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a260c05e02e96aaf1331bc31ed92b0e368403bd
Gerrit-Change-Number: 24259
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Fri, 05 Jun 2026 16:14:50 +0000
Gerrit-HasComments: Yes

Reply via email to