Steve Carlin has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... IMPALA-14849: Upgrade Calcite planner to 1.42 NOTE TO REVIEWERS: Some of the changes are marked with IMPALA-XXXXX both here in the commit message and in the changed files. When this gets a couple of contingent +1s, I will file the Jira and change the XXXXX to reflect the actual Jira. I'm especially hoping for another set of eyes on the changes in subquery.test and grouping-sets.test because it seems that the original planner is producing wrong results. ---START OF ACTUAL COMMIT MESSAGE--- Upgraded to Calcite 1.42. Some problems addressed: - getMaxNumPrecision and getMaxNumScale were made final methods in Calcite causing a compilation error. - A Jira fix changed the interval expression to use CHECKED_TIMES rather than TIMES for the operator. - The avatica dependency is not needed. - 1.42 added new support for some correlated queries which now compile in Calcite and will no longer fallback to the original planner. - The support of some new correlated queries uncovered some incorrect results which can be found in subquery.test and grouping-sets.test. IMPALA-XXXXX has been filed to deal with these incorrect results in the original planner. - Some tests for spilling had to be commented out. The queries in the file used to fallback to the original planner. They succeed now. But the plans generated are different. The original planner produces anti-join queries and the Calcite planner does not. This results in different memory usage. The spilling tests are specifically designed to handle this. IMPALA-XXXXX has been filed to ensure these tests will eventually work for the Calcite planner. Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 --- M java/calcite-planner/pom.xml M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/IntervalExpr.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java M java/pom.xml M testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test M testdata/workloads/functional-query/queries/QueryTest/grouping-sets.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj.test M testdata/workloads/functional-query/queries/QueryTest/subquery.test M tests/common/skip.py M tests/query_test/test_spilling.py 11 files changed, 82 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/24261/3 -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]>
