Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24261 )

Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24261/3/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/24261/3/java/pom.xml@165
PS3, Line 165:         <enabled>false</enabled>
> I accidentally left this in there.  I was consistently testing this with th
Done


http://gerrit.cloudera.org:8080/#/c/24261/3/tests/query_test/test_spilling.py
File tests/query_test/test_spilling.py:

http://gerrit.cloudera.org:8080/#/c/24261/3/tests/query_test/test_spilling.py@115
PS3, Line 115:   @SkipIfCalcite.spilling_plan_different
> For this case, the test file did not handle the exception.  The query timed
That's a bit concerning.



--
To view, visit http://gerrit.cloudera.org:8080/24261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8
Gerrit-Change-Number: 24261
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Mon, 08 Jun 2026 20:37:13 +0000
Gerrit-HasComments: Yes

Reply via email to