Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24261/3/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/24261/3/java/pom.xml@165 PS3, Line 165: <enabled>true</enabled> > Why did these change? I accidentally left this in there. I was consistently testing this with the 1.42.0-SNAPSHOT which relied on this. But now that 1.42 is released, this is not needed. http://gerrit.cloudera.org:8080/#/c/24261/3/tests/query_test/test_spilling.py File tests/query_test/test_spilling.py: http://gerrit.cloudera.org:8080/#/c/24261/3/tests/query_test/test_spilling.py@115 PS3, Line 115: @SkipIfCalcite.spilling_plan_different > Do we need to skip it if the test file handles the exception? For this case, the test file did not handle the exception. The query timed out because it took too long to run. The query is still correct, just not optimal. It contains a long running anti-join but not using the anti-join node. So this needs to be investigated. -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 19:24:25 +0000 Gerrit-HasComments: Yes
