Aleksandr Efimov has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24358 )

Change subject: IMPALA-12955: Slim down profile tool deps
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24358/9/be/src/util/CMakeLists.txt
File be/src/util/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/24358/9/be/src/util/CMakeLists.txt@42
PS9, Line 42:
            : # Keep impala-profile-tool on a small utility subset instea
> Nit: CMake can handle dependencies on things that haven't been declared yet
Done in PS10. Moved the StatusMinimal/StackTraceUtil target_link_libraries() 
entry into be/src/common/CMakeLists.txt next to the StatusMinimal target



--
To view, visit http://gerrit.cloudera.org:8080/24358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 10
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 09 Jun 2026 08:34:51 +0000
Gerrit-HasComments: Yes

Reply via email to