Aleksandr Efimov has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24358 )

Change subject: IMPALA-12955: Slim down profile tool deps
......................................................................


Patch Set 8:

Patch Set 8 addresses Joe review comments:

- Moved stack-trace.* / StackTraceUtil to be/src/util and linked Util to it.
- Renamed the slim Status target to StatusMinimal and linked Common to it 
explicitly.
- Linked StatusMinimal to StackTraceUtil via target_link_libraries().
- Reverted whitespace-only changes in status.cc.
- Added release/shared startup coverage to the dependency test after finding a 
missing GlobalFlags runtime dependency.

Validation:
- git diff --check
- python3 -m py_compile tests/observability/test_profile_tool_dependencies.py
- ./buildall.sh -notests -noclean -cmake_only
- make -C be/src/util impala-profile-tool -j 64
- make Catalog Runtime Exec Scheduling Service Statestore -j 64
- bin/create-test-configuration.sh
- bin/impala-py.test -q tests/observability/test_profile_tool.py
- ./buildall.sh -release -so -notests -noclean -cmake_only
- make -C be/src/util impala-profile-tool -j 64
- be/build/latest/util/impala-profile-tool --help
- bin/impala-py.test -q tests/observability/test_profile_tool_dependencies.py


--
To view, visit http://gerrit.cloudera.org:8080/24358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 8
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Sat, 06 Jun 2026 16:49:25 +0000
Gerrit-HasComments: No

Reply via email to