Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24358 )
Change subject: IMPALA-12955: Slim down profile tool deps ...................................................................... Patch Set 9: Code-Review+1 (1 comment) This is looking great, one small nit then I think this is ready to go. http://gerrit.cloudera.org:8080/#/c/24358/9/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24358/9/be/src/util/CMakeLists.txt@42 PS9, Line 42: # StatusMinimal is defined in be/src/common before util is configured. : target_link_libraries(StatusMinimal PRIVATE StackTraceUtil) Nit: CMake can handle dependencies on things that haven't been declared yet, so it works for this to be in be/src/common/CMakeLists.txt. i.e. This works: add_library(A a.cc ) add_dependencies(A PRIVATE B) add_library(B b.cc ) I think it is clearer to have this target_link_libraries() in be/src/common/CMakeLists.txt. -- To view, visit http://gerrit.cloudera.org:8080/24358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Gerrit-Change-Number: 24358 Gerrit-PatchSet: 9 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 05:30:43 +0000 Gerrit-HasComments: Yes
