Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24425 )
Change subject: IMPALA-15085: DML statements should always shuffle when target table is Iceberg V3 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24425/2/fe/src/main/java/org/apache/impala/analysis/MergeStmt.java File fe/src/main/java/org/apache/impala/analysis/MergeStmt.java: http://gerrit.cloudera.org:8080/#/c/24425/2/fe/src/main/java/org/apache/impala/analysis/MergeStmt.java@124 PS2, Line 124: public boolean requiresShuffle() { return !getShuffleExprs().isEmpty(); } > It'd be a bit more general if this were also the default in DmlStatementBas This patch works; moving this to DmlStatementBase would avoid my having to copy it to my new MigrateStmt as well. -- To view, visit http://gerrit.cloudera.org:8080/24425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7aeed31b832521f0a619c15c116a954c134e4b2 Gerrit-Change-Number: 24425 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 20:19:02 +0000 Gerrit-HasComments: Yes
