Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24425
to look at the new patch set (#5).
Change subject: IMPALA-15085: DML statements should always shuffle when target
table is Iceberg V3
......................................................................
IMPALA-15085: DML statements should always shuffle when target table is Iceberg
V3
Without this patch the MERGE statement didn't always shuffle
before the MERGE SINK for Iceberg V3 tables. For such tables it is
mandatory to shuffle to guarantee that only a single Deletion Vector
is being created per data file.
DELETE/UPDATE worked correctly even before this patch, but added extra
tests anyway.
Testing
* e2e tests added
Change-Id: Ic7aeed31b832521f0a619c15c116a954c134e4b2
Assisted-by: Claude Opus 4.6
---
M fe/src/main/java/org/apache/impala/analysis/DmlStatementBase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M
testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-delete.test
M
testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-update.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-delete.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-update.test
10 files changed, 135 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/24425/5
--
To view, visit http://gerrit.cloudera.org:8080/24425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7aeed31b832521f0a619c15c116a954c134e4b2
Gerrit-Change-Number: 24425
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>