Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24425 )
Change subject: IMPALA-15085: DML statements should always shuffle when target table is Iceberg V3 ...................................................................... Patch Set 1: (1 comment) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24425/2/fe/src/main/java/org/apache/impala/analysis/MergeStmt.java File fe/src/main/java/org/apache/impala/analysis/MergeStmt.java: http://gerrit.cloudera.org:8080/#/c/24425/2/fe/src/main/java/org/apache/impala/analysis/MergeStmt.java@124 PS2, Line 124: public boolean requiresShuffle() { return !getShuffleExprs().isEmpty(); } > And I'd put it under getShuffleExprs() there for symmetry. I wrote about it in the commit message: Currently INSERT statements can legitimetely skip adding an extra EXCHANGE node, even when the table is partitioned. They do it when the input fragment's partitioning is compatible with the table's partitions. Maybe I could cleanup shuffle exprs / partition exprs a bit. Current getShuffleExprs() return partitionExprs() by default. Instead, they could return empty list by default, then empty shuffle exprs => partition exprs are used, but shuffling is not enforced non-empty shuffle exprs => use them and shuffling is enforced -- To view, visit http://gerrit.cloudera.org:8080/24425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7aeed31b832521f0a619c15c116a954c134e4b2 Gerrit-Change-Number: 24425 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2026 16:01:29 +0000 Gerrit-HasComments: Yes
