Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24446 )

Change subject: IMPALA-15093: Use RE2 For Profile Analyzer Regex
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-redaction.cc
File be/src/service/query-profile-redaction.cc:

http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-redaction.cc@77
PS1, Line 77:     
R"((\b(?:(?:25[0-5]|2[0-4]\d|1\d\d|[1-9]?\d)\.){3}(?:25[0-5]|2[0-4]\d|1\d\d|[1-9]?\d)\b))");
line too long (96 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1343b2f049758e862d229f2a647273de56855c4
Gerrit-Change-Number: 24446
Gerrit-PatchSet: 1
Gerrit-Owner: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 11 Jun 2026 21:25:49 +0000
Gerrit-HasComments: Yes

Reply via email to