Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24446 )
Change subject: IMPALA-15093: Use RE2 For Profile Analyzer Regex ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24446/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24446/1//COMMIT_MSG@9 PS1, Line 9: Replace std::regex usage in query profile parsing/redaction with re2::RE2 so the AI : analyzer flow uses a single regex engine end-to-end. This updates pattern : definitions and matching/replacement/extraction paths (query ID, fragment/operator : parsing, resource estimate parsing, and redaction token collection) while preserving : existing behavior. nit. Each line of commit message should be 72 characters or fewer if possible. https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala http://gerrit.cloudera.org:8080/#/c/24446/1//COMMIT_MSG@14 PS1, Line 14: Could you please also mention the test you ran for this patch here? -- To view, visit http://gerrit.cloudera.org:8080/24446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1343b2f049758e862d229f2a647273de56855c4 Gerrit-Change-Number: 24446 Gerrit-PatchSet: 1 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 01:05:07 +0000 Gerrit-HasComments: Yes
