Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24446 )
Change subject: IMPALA-15093: Use RE2 For Profile Analyzer Regex ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@775 PS1, Line 775: const string_view plan_text(plan_value.GetString(), plan_value.GetStringLength()); Can this `plan_text` variable be eliminated? http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@790 PS1, Line 790: const string_view plan_text(plan_value.GetString(), plan_value.GetStringLength()); Can this `plan_text` variable be eliminated? http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@1125 PS1, Line 1125: double QueryProfileToolAccessor::ParseDurationMs(string_view value) const { Suggestion: This change would be a great time to add ctest tests for this function. http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@1134 PS1, Line 1134: const string numeric_text(numeric_component.data(), numeric_component.size()); Can this extra string create be eliminated? http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-redaction.cc@99 PS1, Line 99: static vector<string> CollectRegexMatches( Suggestion: This change would be a great time to add ctest tests for this function. -- To view, visit http://gerrit.cloudera.org:8080/24446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1343b2f049758e862d229f2a647273de56855c4 Gerrit-Change-Number: 24446 Gerrit-PatchSet: 1 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 18:47:28 +0000 Gerrit-HasComments: Yes
