Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg ...................................................................... Patch Set 13: (7 comments) http://gerrit.cloudera.org:8080/#/c/24489/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24489/13//COMMIT_MSG@9 PS13, Line 9: Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2 This should be at the end. http://gerrit.cloudera.org:8080/#/c/24489/13//COMMIT_MSG@12 PS13, Line 12: Fix the redundant whitespaces and end of lines. http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1476 PS13, Line 1476: props.put(org.apache.iceberg.EnvironmentContext.ENGINE_NAME, Other engines set the EnvironmentContext: https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java#L734 This method might also not the best to set these static configs. http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1479 PS13, Line 1479: 4.4.0 Still an old Impala version being hardcoded here. http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1903 PS13, Line 1903: setIcebergEngineContext It's never getting invoked. http://gerrit.cloudera.org:8080/#/c/24489/13/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24489/13/tests/query_test/test_iceberg.py@2864 PS13, Line 2864: assert properties.get('engine.name') == 'impala' We should also verify that metadata queries return these fields, e.g. they should be in the summary column: select * from unique_database.engine_context_preset_test.snapshots; http://gerrit.cloudera.org:8080/#/c/24489/13/tests/query_test/test_iceberg.py@2865 PS13, Line 2865: properties We should verify that it is the current version, i.e. use os.getenv("IMPALA_VERSION") -- To view, visit http://gerrit.cloudera.org:8080/24489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2 Gerrit-Change-Number: 24489 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 14:58:12 +0000 Gerrit-HasComments: Yes
