Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24489 )

Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................


Patch Set 15:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24489/15/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
File 
fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java:

http://gerrit.cloudera.org:8080/#/c/24489/15/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@66
PS15, Line 66:     // Inject the engine and version details straight into the 
table creation properties map
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/24489/15/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@72
PS15, Line 72:     return class_getName().equals("") ? null : 
hadoopCatalog.createTable(identifier, schema, spec, /*location=*/null,
line too long (117 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 06 Jul 2026 17:17:53 +0000
Gerrit-HasComments: Yes

Reply via email to