Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... Patch Set 7: (5 comments) A few nits that I missed tagging previously. http://gerrit.cloudera.org:8080/#/c/24261/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24261/7//COMMIT_MSG@26 PS7, Line 26: IMPALA-XXXXX replace with Impala jira id http://gerrit.cloudera.org:8080/#/c/24261/7//COMMIT_MSG@34 PS7, Line 34: IMPALA-XXXXX same as above http://gerrit.cloudera.org:8080/#/c/24261/7/testdata/workloads/functional-query/queries/QueryTest/spilling-naaj.test File testdata/workloads/functional-query/queries/QueryTest/spilling-naaj.test: http://gerrit.cloudera.org:8080/#/c/24261/7/testdata/workloads/functional-query/queries/QueryTest/spilling-naaj.test@24 PS7, Line 24: # (to be filled in after review) nit: remove this line (and similar occurrences in the rest of the file) http://gerrit.cloudera.org:8080/#/c/24261/7/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/24261/7/tests/common/skip.py@310 PS7, Line 310: IMPALA-XXXXX nit: replace with the actual Impala jira id http://gerrit.cloudera.org:8080/#/c/24261/7/tests/query_test/test_spilling.py File tests/query_test/test_spilling.py: http://gerrit.cloudera.org:8080/#/c/24261/7/tests/query_test/test_spilling.py@111 PS7, Line 111: # (to be filled in after review) nit: remove this line -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Sun, 28 Jun 2026 19:53:41 +0000 Gerrit-HasComments: Yes
