Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24261/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24261/4//COMMIT_MSG@19 PS4, Line 19: Some problems addressed: > In IMPALA-14849, you had said "There is some code in RexCallConverter.java I tested this commit after removing the code and it still works, so the changes are now included. http://gerrit.cloudera.org:8080/#/c/24261/4/testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test File testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test: http://gerrit.cloudera.org:8080/#/c/24261/4/testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test@125 PS4, Line 125: ---- RESULTS > Since the subquery has a LIMIT without order-by, it is possible it could pr So the error was grabbed from a junit test here: https://github.com/scarlin-cloudera/impala/blob/master/fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java#L489-L491 So it definitely had something to do with LIMIT. I added an order by to ensure this test isn't flaky. -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2026 11:33:05 +0000 Gerrit-HasComments: Yes
