Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... Patch Set 6: (1 comment) One comment about test duplication otherwise this is looking good. http://gerrit.cloudera.org:8080/#/c/24261/4/testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test File testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test: http://gerrit.cloudera.org:8080/#/c/24261/4/testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test@125 PS4, Line 125: INT > So the error was grabbed from a junit test here: Ok, it turns out the next test right after this is the same one that has the ORDER BY. So you can remove the next test to avoid duplication. The tests in AnayzeSubqueriesTest were meant to catch analyze error only but if we want to run it end-to-end, then we should use the order by with limit. -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2026 17:42:37 +0000 Gerrit-HasComments: Yes
