Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24536 )
Change subject: WIP: Add GEOMETRY column support for Iceberg and Parquet ...................................................................... Patch Set 1: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24536/1/common/thrift/parquet.thrift File common/thrift/parquet.thrift: http://gerrit.cloudera.org:8080/#/c/24536/1/common/thrift/parquet.thrift@329 PS1, Line 329: struct Float16Type {} // allowed for FIXED[2], must be encoded as raw FLOAT16 bytes (see LogicalTypes.md) line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/24536/1/common/thrift/parquet.thrift@484 PS1, Line 484: 5: DecimalType DECIMAL // use ConvertedType DECIMAL + SchemaElement.{scale, precision} line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24536/1/common/thrift/parquet.thrift@760 PS1, Line 760: definition_levels_byte_length + repetition_levels_byte_length and compressed_page_size (included) line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/24536/1/common/thrift/parquet.thrift@990 PS1, Line 990: * reference implementations that will read externally stored column data if this field is populated line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/24536/1/tests/custom_cluster/test_geospatial_library.py File tests/custom_cluster/test_geospatial_library.py: http://gerrit.cloudera.org:8080/#/c/24536/1/tests/custom_cluster/test_geospatial_library.py@85 PS1, Line 85: v flake8: U100 Unused argument 'vector' -- To view, visit http://gerrit.cloudera.org:8080/24536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d8c12a6b71708646fbfc06a6dd8f7aaf4f5e6b Gerrit-Change-Number: 24536 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 03 Jul 2026 07:20:58 +0000 Gerrit-HasComments: Yes
